-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currency conversion: add XAG + XAU #2123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It requires changes in stores/FiatStore.ts
as well.
Have a look at #1960 for the reference
For that, I was confused with what symbol should we use for XAG and XAU. |
Probably yes.
|
Good, question: |
@shivamgupta2020 We have some failing tests in commits. Reset and force push them again |
@shivamgupta2020 moving forward you may want to also cut PRs from a new branch, instead of |
I will take care of your advice in my future contributions. Thanks for your valuable input @kaloudis. |
Added XAG+ XAU currency.
Tried to fix #2113